Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1200): language button click fix #1211

Merged

Conversation

absolutezero13
Copy link
Contributor

Description

Language button can be clicked now on Mobile devices.

discord username: afetharita#0001

closes #issue #1200

Please describe your changes. Also describe your aim and content. Do not forget to list the dependencies required caused by those changes.

## Things to check before creating a PR

  • I have inspected my topic, checked.
  • If it is a core feature, executed detailed tests.

Creating PR rules

  • PR must be created for an issue with approved tag. Otherwise PR will be rejected.
  • Relevant issue number: The issue number related to PR must be attached to head of PR header, after prefix after prefix # must be attached in parenthesis. A header like this could be used "prefix(#issue_number): PR header" .
  • A descriptive and understandable title: The PR title should clearly describe the nature and purpose of the changes. The PR title should be the first thing displayed when the PR is opened. And it should follow the semantic commit rules. For example, a title like "docs(#issueId): Add README.md" can be used.
  • Related file selection: Only relevant files should be touched and no other files should be affected.
  • Format and Lint Suitability : The code should be made in accordance with a certain format standard and examined according to the lint rules.
  • Clean commit history: The commits where the changes are made should be clear and organized.
  • Opening PR when job is completed: PR should be opened when job is completed and sent for review by other team members.

Changes

  • A new feature (a change that adds a new feature, not a breaking change)
  • A new refactor (a change that is not a breaking change, that improves the readability or performance of the code)
  • A breaking change
  • Documentation change

How were these changes tested?

Please describe the tests you did to test the changes you made. Please also specify your test configuration.

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

@absolutezero13 absolutezero13 requested a review from a team February 28, 2023 17:14
@vercel
Copy link

vercel bot commented Feb 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
deprem-yardim-frontend ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 28, 2023 at 5:15PM (UTC)

@eraygundogmus eraygundogmus added the waiting-test waiting for test approval label Feb 28, 2023
@eraygundogmus eraygundogmus merged commit 0375ab9 into acikyazilimagi:development Mar 2, 2023
eraygundogmus added a commit that referenced this pull request Mar 2, 2023
* fix(#855): data sources popup fix (#1209)

* fix: data sources popup fix

* fix: env sample issue

* fix: name change

* fix: style improvements

* fix: style improvements

* fix: explanation text added back

* fix: dynamic viewport unit added

* fix: env sample issue

* fix: exp texts removed

* fix: language button click fix (#1211)

---------

Co-authored-by: İlker Sarıca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-test waiting for test approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants