ACMS-3680: Allow strictConfigSchema check in tests.

acquia · Apr 26, 2024 · 5e63584 · 5e63584
1 parent da404ed
commit 5e63584
Show file tree

Hide file tree

Showing 36 changed files with 0 additions and 448 deletions.
diff --git a/modules/acquia_cms_article/tests/src/ExistingSite/ArticleImageDamTest.php b/modules/acquia_cms_article/tests/src/ExistingSite/ArticleImageDamTest.php
@@ -19,10 +19,6 @@ class ArticleImageDamTest extends ExistingSiteBase {
 
   use ConfigurationTraits;
 
-  // @codingStandardsIgnoreStart
-  protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
-
   /**
    * {@inheritdoc}
    */

diff --git a/modules/acquia_cms_article/tests/src/Functional/ArticleTest.php b/modules/acquia_cms_article/tests/src/Functional/ArticleTest.php
@@ -34,21 +34,6 @@ class ArticleTest extends ContentTypeTestBase {
     'schema_article',
   ];
 
-  /**
-   * Disable strict config schema checks in this test.
-   *
-   * Cohesion has a lot of config schema errors, and until they are all fixed,
-   * this test cannot pass unless we disable strict config schema checking
-   * altogether. Since strict config schema isn't critically important in
-   * testing this functionality, it's okay to disable it for now, but it should
-   * be re-enabled (i.e., this property should be removed) as soon as possible.
-   *
-   * @var bool
-   */
-  // @codingStandardsIgnoreStart
-  protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
-
   /**
    * {@inheritdoc}
    */

diff --git a/modules/acquia_cms_article/tests/src/Functional/BlogTest.php b/modules/acquia_cms_article/tests/src/Functional/BlogTest.php
@@ -41,21 +41,6 @@ class BlogTest extends BrowserTestBase {
     'schema_article',
   ];
 
-  /**
-   * Disable strict config schema checks in this test.
-   *
-   * Cohesion has a lot of config schema errors, and until they are all fixed,
-   * this test cannot pass unless we disable strict config schema checking
-   * altogether. Since strict config schema isn't critically important in
-   * testing this functionality, it's okay to disable it for now, but it should
-   * be re-enabled (i.e., this property should be removed) as soon as possible.
-   *
-   * @var bool
-   */
-  // @codingStandardsIgnoreStart
-  protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
-
   /**
    * {@inheritdoc}
    */

diff --git a/modules/acquia_cms_audio/tests/src/Functional/AudioTest.php b/modules/acquia_cms_audio/tests/src/Functional/AudioTest.php
@@ -21,20 +21,6 @@ class AudioTest extends MediaTypeTestBase {
    */
   protected static $modules = ['acquia_cms_audio'];
 
-  /**
-   * Disable strict config schema checks in this test.
-   *
-   * Cohesion has a lot of config schema errors, and until they are all fixed,
-   * this test cannot pass unless we disable strict config schema checking
-   * altogether. Since strict config schema isn't critically important in
-   * testing this functionality, it's okay to disable it for now, but it should
-   * be re-enabled (i.e., this property should be removed) as soon as possible.
-   *
-   * @var bool
-   */
-  // @codingStandardsIgnoreStart
-  protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
 
   /**
    * {@inheritdoc}

diff --git a/...ia_cms_common/modules/acquia_cms_support/tests/src/Functional/AcquiaCmsConfigSyncTest.php b/...ia_cms_common/modules/acquia_cms_support/tests/src/Functional/AcquiaCmsConfigSyncTest.php
@@ -20,21 +20,6 @@ class AcquiaCmsConfigSyncTest extends BrowserTestBase {
    */
   protected $defaultTheme = 'stark';
 
-  /**
-   * Disable strict config schema checks in this test.
-   *
-   * Cohesion has a lot of config schema errors, and until they are all fixed,
-   * this test cannot pass unless we disable strict config schema checking
-   * altogether. Since strict config schema isn't critically important in
-   * testing this functionality, it's okay to disable it for now, but it should
-   * be re-enabled (i.e., this property should be removed) as soon as possible.
-   *
-   * @var bool
-   */
-  // @codingStandardsIgnoreStart
-  protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
-
   /**
    * {@inheritdoc}
    */

diff --git a/modules/acquia_cms_common/tests/src/Functional/BasicPermissionsTest.php b/modules/acquia_cms_common/tests/src/Functional/BasicPermissionsTest.php
@@ -31,21 +31,6 @@ class BasicPermissionsTest extends BrowserTestBase {
     'views',
   ];
 
-  /**
-   * Disable strict config schema checks in this test.
-   *
-   * Cohesion has a lot of config schema errors, and until they are all fixed,
-   * this test cannot pass unless we disable strict config schema checking
-   * altogether. Since strict config schema isn't critically important in
-   * testing this functionality, it's okay to disable it for now, but it should
-   * be re-enabled (i.e., this property should be removed) as soon as possible.
-   *
-   * @var bool
-   */
-  // @codingStandardsIgnoreStart
-  protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
-
   /**
    * Tests the basic module permissions.
    *

diff --git a/modules/acquia_cms_common/tests/src/Functional/EntityPermissionsTestBase.php b/modules/acquia_cms_common/tests/src/Functional/EntityPermissionsTestBase.php
@@ -17,21 +17,6 @@ abstract class EntityPermissionsTestBase extends BrowserTestBase {
    */
   protected $defaultTheme = 'stark';
 
-  /**
-   * Disable strict config schema checks in this test.
-   *
-   * Cohesion has a lot of config schema errors, and until they are all fixed,
-   * this test cannot pass unless we disable strict config schema checking
-   * altogether. Since strict config schema isn't critically important in
-   * testing this functionality, it's okay to disable it for now, but it should
-   * be re-enabled (i.e., this property should be removed) as soon as possible.
-   *
-   * @var bool
-   */
-  // @codingStandardsIgnoreStart
-  protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
-
   /**
    * Defines an array of role which should & shouldn't exist.
    */

diff --git a/modules/acquia_cms_common/tests/src/FunctionalJavascript/Ckeditor5ConfigurationTestBase.php b/modules/acquia_cms_common/tests/src/FunctionalJavascript/Ckeditor5ConfigurationTestBase.php
@@ -31,21 +31,6 @@ abstract class Ckeditor5ConfigurationTestBase extends WebDriverTestBase {
     'acquia_cms_common',
   ];
 
-  /**
-   * Disable strict config schema checks in this test.
-   *
-   * Cohesion has a lot of config schema errors, and until they are all fixed,
-   * this test cannot pass unless we disable strict config schema checking
-   * altogether. Since strict config schema isn't critically important in
-   * testing this functionality, it's okay to disable it for now, but it should
-   * be re-enabled (i.e., this property should be removed) as soon as possible.
-   *
-   * @var bool
-   */
-  // @codingStandardsIgnoreStart
-  protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
-
   /**
    * {@inheritdoc}
    */

diff --git a/modules/acquia_cms_document/tests/src/Functional/DocumentTest.php b/modules/acquia_cms_document/tests/src/Functional/DocumentTest.php
@@ -21,21 +21,6 @@ class DocumentTest extends MediaTypeTestBase {
    */
   protected static $modules = ['acquia_cms_document'];
 
-  /**
-   * Disable strict config schema checks in this test.
-   *
-   * Cohesion has a lot of config schema errors, and until they are all fixed,
-   * this test cannot pass unless we disable strict config schema checking
-   * altogether. Since strict config schema isn't critically important in
-   * testing this functionality, it's okay to disable it for now, but it should
-   * be re-enabled (i.e., this property should be removed) as soon as possible.
-   *
-   * @var bool
-   */
-  // @codingStandardsIgnoreStart
-  protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
-
   /**
    * {@inheritdoc}
    */

diff --git a/modules/acquia_cms_document/tests/src/FunctionalJavascript/DocumentEmbedTest.php b/modules/acquia_cms_document/tests/src/FunctionalJavascript/DocumentEmbedTest.php
@@ -20,21 +20,6 @@ class DocumentEmbedTest extends MediaEmbedTestBase {
    */
   protected static $modules = ['acquia_cms_document'];
 
-  /**
-   * Disable strict config schema checks in this test.
-   *
-   * Cohesion has a lot of config schema errors, and until they are all fixed,
-   * this test cannot pass unless we disable strict config schema checking
-   * altogether. Since strict config schema isn't critically important in
-   * testing this functionality, it's okay to disable it for now, but it should
-   * be re-enabled (i.e., this property should be removed) as soon as possible.
-   *
-   * @var bool
-   */
-  // @codingStandardsIgnoreStart
-  protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
-
   /**
    * {@inheritdoc}
    */

diff --git a/modules/acquia_cms_event/tests/src/ExistingSite/EventImageDamTest.php b/modules/acquia_cms_event/tests/src/ExistingSite/EventImageDamTest.php
@@ -19,10 +19,6 @@ class EventImageDamTest extends ExistingSiteBase {
 
   use ConfigurationTraits;
 
-  // @codingStandardsIgnoreStart
-  protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
-
   /**
    * {@inheritdoc}
    */

diff --git a/modules/acquia_cms_event/tests/src/Functional/EventTest.php b/modules/acquia_cms_event/tests/src/Functional/EventTest.php
@@ -37,21 +37,6 @@ class EventTest extends ContentTypeTestBase {
 
   private $defaultTime;
 
-  /**
-   * Disable strict config schema checks in this test.
-   *
-   * Cohesion has a lot of config schema errors, and until they are all fixed,
-   * this test cannot pass unless we disable strict config schema checking
-   * altogether. Since strict config schema isn't critically important in
-   * testing this functionality, it's okay to disable it for now, but it should
-   * be re-enabled (i.e., this property should be removed) as soon as possible.
-   *
-   * @var bool
-   */
-  // @codingStandardsIgnoreStart
-  protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
-
   /**
    * {@inheritdoc}
    */

diff --git a/modules/acquia_cms_image/tests/src/Functional/ImageTest.php b/modules/acquia_cms_image/tests/src/Functional/ImageTest.php
@@ -20,21 +20,6 @@ class ImageTest extends MediaTypeTestBase {
    */
   protected static $modules = ['acquia_cms_image'];
 
-  /**
-   * Disable strict config schema checks in this test.
-   *
-   * Cohesion has a lot of config schema errors, and until they are all fixed,
-   * this test cannot pass unless we disable strict config schema checking
-   * altogether. Since strict config schema isn't critically important in
-   * testing this functionality, it's okay to disable it for now, but it should
-   * be re-enabled (i.e., this property should be removed) as soon as possible.
-   *
-   * @var bool
-   */
-  // @codingStandardsIgnoreStart
-  protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
-
   /**
    * {@inheritdoc}
    */

diff --git a/modules/acquia_cms_image/tests/src/FunctionalJavascript/ImageEmbedTest.php b/modules/acquia_cms_image/tests/src/FunctionalJavascript/ImageEmbedTest.php
@@ -20,21 +20,6 @@ class ImageEmbedTest extends MediaEmbedTestBase {
    */
   protected static $modules = ['acquia_cms_common', 'acquia_cms_image', 'focal_point'];
 
-  /**
-   * Disable strict config schema checks in this test.
-   *
-   * Cohesion has a lot of config schema errors, and until they are all fixed,
-   * this test cannot pass unless we disable strict config schema checking
-   * altogether. Since strict config schema isn't critically important in
-   * testing this functionality, it's okay to disable it for now, but it should
-   * be re-enabled (i.e., this property should be removed) as soon as possible.
-   *
-   * @var bool
-   */
-  // @codingStandardsIgnoreStart
-  protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
-
   /**
    * {@inheritdoc}
    */

diff --git a/modules/acquia_cms_image/tests/src/Kernel/SiteLogoTest.php b/modules/acquia_cms_image/tests/src/Kernel/SiteLogoTest.php
@@ -63,21 +63,6 @@ class SiteLogoTest extends KernelTestBase {
    */
   protected $siteLogo;
 
-  /**
-   * Disable strict config schema checks in this test.
-   *
-   * There are some config schema errors, and until they are all fixed,
-   * this test cannot pass unless we disable strict config schema checking
-   * altogether. Since strict config schema isn't critically important in
-   * testing this functionality, it's okay to disable it for now, but it should
-   * be re-enabled (i.e., this property should be removed) as soon as possible.
-   *
-   * @var bool
-   */
-  // @codingStandardsIgnoreStart
-  protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
-
   /**
    * {@inheritdoc}
    */

diff --git a/modules/acquia_cms_page/tests/src/ExistingSite/PageImageDamTest.php b/modules/acquia_cms_page/tests/src/ExistingSite/PageImageDamTest.php
@@ -19,10 +19,6 @@ class PageImageDamTest extends ExistingSiteBase {
 
   use ConfigurationTraits;
 
-  // @codingStandardsIgnoreStart
-	protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
-
   /**
    * {@inheritdoc}
    */

diff --git a/modules/acquia_cms_page/tests/src/Functional/PageTest.php b/modules/acquia_cms_page/tests/src/Functional/PageTest.php
@@ -32,21 +32,6 @@ class PageTest extends ContentTypeTestBase {
     'schema_article',
   ];
 
-  /**
-   * Disable strict config schema checks in this test.
-   *
-   * Cohesion has a lot of config schema errors, and until they are all fixed,
-   * this test cannot pass unless we disable strict config schema checking
-   * altogether. Since strict config schema isn't critically important in
-   * testing this functionality, it's okay to disable it for now, but it should
-   * be re-enabled (i.e., this property should be removed) as soon as possible.
-   *
-   * @var bool
-   */
-  // @codingStandardsIgnoreStart
-  protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
-
   /**
    * {@inheritdoc}
    */

diff --git a/modules/acquia_cms_page/tests/src/Kernel/PageWithLayoutCanvasFieldTest.php b/modules/acquia_cms_page/tests/src/Kernel/PageWithLayoutCanvasFieldTest.php
@@ -29,9 +29,6 @@ class PageWithLayoutCanvasFieldTest extends FieldKernelTestBase {
   /**
    * {@inheritdoc}
    */
-  // @codingStandardsIgnoreStart
-  protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
 
   /**
    * The field_config object.

diff --git a/modules/acquia_cms_person/tests/src/ExistingSite/PersonImageDamTest.php b/modules/acquia_cms_person/tests/src/ExistingSite/PersonImageDamTest.php
@@ -19,10 +19,6 @@ class PersonImageDamTest extends ExistingSiteBase {
 
   use ConfigurationTraits;
 
-  // @codingStandardsIgnoreStart
-  protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
-
   /**
    * {@inheritdoc}
    */

diff --git a/modules/acquia_cms_person/tests/src/Functional/PersonTest.php b/modules/acquia_cms_person/tests/src/Functional/PersonTest.php
@@ -35,21 +35,6 @@ class PersonTest extends ContentTypeTestBase {
     'schema_person',
   ];
 
-  /**
-   * Disable strict config schema checks in this test.
-   *
-   * Cohesion has a lot of config schema errors, and until they are all fixed,
-   * this test cannot pass unless we disable strict config schema checking
-   * altogether. Since strict config schema isn't critically important in
-   * testing this functionality, it's okay to disable it for now, but it should
-   * be re-enabled (i.e., this property should be removed) as soon as possible.
-   *
-   * @var bool
-   */
-  // @codingStandardsIgnoreStart
-  protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
-
   /**
    * {@inheritdoc}
    */

diff --git a/modules/acquia_cms_place/tests/src/ExistingSite/PlaceImageDamTest.php b/modules/acquia_cms_place/tests/src/ExistingSite/PlaceImageDamTest.php
@@ -19,10 +19,6 @@ class PlaceImageDamTest extends ExistingSiteBase {
 
   use ConfigurationTraits;
 
-  // @codingStandardsIgnoreStart
-  protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
-
   /**
    * {@inheritdoc}
    */