Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACMS-1927: Spike php 8.3 for ACMS. #1692

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

ACMS-1927: Spike php 8.3 for ACMS. #1692

wants to merge 7 commits into from

Conversation

apathak18
Copy link
Contributor

Motivation

Fixes ACMS-1927

Proposed changes
Spike for PHP 8.3 with ACMS

@rajeshreeputra
Copy link
Contributor

@apathak18 update ORCA_JOB form - ISOLATED_TEST_ON_CURRENT to - ISOLATED_TEST_ON_NEXT_MINOR as 10.1.x is not supported with PHP 8.3.

Copy link
Contributor

@rajeshreeputra rajeshreeputra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update prophecy to 1.18.0 as it is released.

.github/workflows/acquia_cms_ci.workflow.yml Outdated Show resolved Hide resolved
.github/workflows/acquia_cms_ci.workflow.yml Outdated Show resolved Hide resolved
.github/workflows/acquia_cms_ci.workflow.yml Outdated Show resolved Hide resolved
.github/workflows/acquia_cms_ci.workflow.yml Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@deepakmishra2
Copy link
Contributor

@apathak18 please rebase this with develop

composer.json Outdated Show resolved Hide resolved
@apathak18 apathak18 marked this pull request as ready for review December 12, 2023 13:10
Copy link
Contributor

@deepakmishra2 deepakmishra2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants