Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACMS-3680: Allow strictConfigSchema check in tests. #1814

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@ class ArticleImageDamTest extends ExistingSiteBase {

use ConfigurationTraits;

// @codingStandardsIgnoreStart
protected $strictConfigSchema = FALSE;
// @codingStandardsIgnoreEnd

/**
* {@inheritdoc}
*/
Expand Down
15 changes: 0 additions & 15 deletions modules/acquia_cms_article/tests/src/Functional/ArticleTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,21 +34,6 @@ class ArticleTest extends ContentTypeTestBase {
'schema_article',
];

/**
* Disable strict config schema checks in this test.
*
* Cohesion has a lot of config schema errors, and until they are all fixed,
* this test cannot pass unless we disable strict config schema checking
* altogether. Since strict config schema isn't critically important in
* testing this functionality, it's okay to disable it for now, but it should
* be re-enabled (i.e., this property should be removed) as soon as possible.
*
* @var bool
*/
// @codingStandardsIgnoreStart
protected $strictConfigSchema = FALSE;
// @codingStandardsIgnoreEnd

/**
* {@inheritdoc}
*/
Expand Down
15 changes: 0 additions & 15 deletions modules/acquia_cms_article/tests/src/Functional/BlogTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,21 +41,6 @@ class BlogTest extends BrowserTestBase {
'schema_article',
];

/**
* Disable strict config schema checks in this test.
*
* Cohesion has a lot of config schema errors, and until they are all fixed,
* this test cannot pass unless we disable strict config schema checking
* altogether. Since strict config schema isn't critically important in
* testing this functionality, it's okay to disable it for now, but it should
* be re-enabled (i.e., this property should be removed) as soon as possible.
*
* @var bool
*/
// @codingStandardsIgnoreStart
protected $strictConfigSchema = FALSE;
// @codingStandardsIgnoreEnd

/**
* {@inheritdoc}
*/
Expand Down
14 changes: 0 additions & 14 deletions modules/acquia_cms_audio/tests/src/Functional/AudioTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,20 +21,6 @@ class AudioTest extends MediaTypeTestBase {
*/
protected static $modules = ['acquia_cms_audio'];

/**
* Disable strict config schema checks in this test.
*
* Cohesion has a lot of config schema errors, and until they are all fixed,
* this test cannot pass unless we disable strict config schema checking
* altogether. Since strict config schema isn't critically important in
* testing this functionality, it's okay to disable it for now, but it should
* be re-enabled (i.e., this property should be removed) as soon as possible.
*
* @var bool
*/
// @codingStandardsIgnoreStart
protected $strictConfigSchema = FALSE;
// @codingStandardsIgnoreEnd

/**
* {@inheritdoc}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,21 +20,6 @@ class AcquiaCmsConfigSyncTest extends BrowserTestBase {
*/
protected $defaultTheme = 'stark';

/**
* Disable strict config schema checks in this test.
*
* Cohesion has a lot of config schema errors, and until they are all fixed,
* this test cannot pass unless we disable strict config schema checking
* altogether. Since strict config schema isn't critically important in
* testing this functionality, it's okay to disable it for now, but it should
* be re-enabled (i.e., this property should be removed) as soon as possible.
*
* @var bool
*/
// @codingStandardsIgnoreStart
protected $strictConfigSchema = FALSE;
// @codingStandardsIgnoreEnd

/**
* {@inheritdoc}
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,21 +31,6 @@ class BasicPermissionsTest extends BrowserTestBase {
'views',
];

/**
* Disable strict config schema checks in this test.
*
* Cohesion has a lot of config schema errors, and until they are all fixed,
* this test cannot pass unless we disable strict config schema checking
* altogether. Since strict config schema isn't critically important in
* testing this functionality, it's okay to disable it for now, but it should
* be re-enabled (i.e., this property should be removed) as soon as possible.
*
* @var bool
*/
// @codingStandardsIgnoreStart
protected $strictConfigSchema = FALSE;
// @codingStandardsIgnoreEnd

/**
* Tests the basic module permissions.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,21 +17,6 @@ abstract class EntityPermissionsTestBase extends BrowserTestBase {
*/
protected $defaultTheme = 'stark';

/**
* Disable strict config schema checks in this test.
*
* Cohesion has a lot of config schema errors, and until they are all fixed,
* this test cannot pass unless we disable strict config schema checking
* altogether. Since strict config schema isn't critically important in
* testing this functionality, it's okay to disable it for now, but it should
* be re-enabled (i.e., this property should be removed) as soon as possible.
*
* @var bool
*/
// @codingStandardsIgnoreStart
protected $strictConfigSchema = FALSE;
// @codingStandardsIgnoreEnd

/**
* Defines an array of role which should & shouldn't exist.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,21 +31,6 @@ abstract class Ckeditor5ConfigurationTestBase extends WebDriverTestBase {
'acquia_cms_common',
];

/**
* Disable strict config schema checks in this test.
*
* Cohesion has a lot of config schema errors, and until they are all fixed,
* this test cannot pass unless we disable strict config schema checking
* altogether. Since strict config schema isn't critically important in
* testing this functionality, it's okay to disable it for now, but it should
* be re-enabled (i.e., this property should be removed) as soon as possible.
*
* @var bool
*/
// @codingStandardsIgnoreStart
protected $strictConfigSchema = FALSE;
// @codingStandardsIgnoreEnd

/**
* {@inheritdoc}
*/
Expand Down
15 changes: 0 additions & 15 deletions modules/acquia_cms_document/tests/src/Functional/DocumentTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,21 +21,6 @@ class DocumentTest extends MediaTypeTestBase {
*/
protected static $modules = ['acquia_cms_document'];

/**
* Disable strict config schema checks in this test.
*
* Cohesion has a lot of config schema errors, and until they are all fixed,
* this test cannot pass unless we disable strict config schema checking
* altogether. Since strict config schema isn't critically important in
* testing this functionality, it's okay to disable it for now, but it should
* be re-enabled (i.e., this property should be removed) as soon as possible.
*
* @var bool
*/
// @codingStandardsIgnoreStart
protected $strictConfigSchema = FALSE;
// @codingStandardsIgnoreEnd

/**
* {@inheritdoc}
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,21 +20,6 @@ class DocumentEmbedTest extends MediaEmbedTestBase {
*/
protected static $modules = ['acquia_cms_document'];

/**
* Disable strict config schema checks in this test.
*
* Cohesion has a lot of config schema errors, and until they are all fixed,
* this test cannot pass unless we disable strict config schema checking
* altogether. Since strict config schema isn't critically important in
* testing this functionality, it's okay to disable it for now, but it should
* be re-enabled (i.e., this property should be removed) as soon as possible.
*
* @var bool
*/
// @codingStandardsIgnoreStart
protected $strictConfigSchema = FALSE;
// @codingStandardsIgnoreEnd

/**
* {@inheritdoc}
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@ class EventImageDamTest extends ExistingSiteBase {

use ConfigurationTraits;

// @codingStandardsIgnoreStart
protected $strictConfigSchema = FALSE;
// @codingStandardsIgnoreEnd

/**
* {@inheritdoc}
*/
Expand Down
15 changes: 0 additions & 15 deletions modules/acquia_cms_event/tests/src/Functional/EventTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -37,21 +37,6 @@ class EventTest extends ContentTypeTestBase {

private $defaultTime;

/**
* Disable strict config schema checks in this test.
*
* Cohesion has a lot of config schema errors, and until they are all fixed,
* this test cannot pass unless we disable strict config schema checking
* altogether. Since strict config schema isn't critically important in
* testing this functionality, it's okay to disable it for now, but it should
* be re-enabled (i.e., this property should be removed) as soon as possible.
*
* @var bool
*/
// @codingStandardsIgnoreStart
protected $strictConfigSchema = FALSE;
// @codingStandardsIgnoreEnd

/**
* {@inheritdoc}
*/
Expand Down
15 changes: 0 additions & 15 deletions modules/acquia_cms_image/tests/src/Functional/ImageTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,21 +20,6 @@ class ImageTest extends MediaTypeTestBase {
*/
protected static $modules = ['acquia_cms_image'];

/**
* Disable strict config schema checks in this test.
*
* Cohesion has a lot of config schema errors, and until they are all fixed,
* this test cannot pass unless we disable strict config schema checking
* altogether. Since strict config schema isn't critically important in
* testing this functionality, it's okay to disable it for now, but it should
* be re-enabled (i.e., this property should be removed) as soon as possible.
*
* @var bool
*/
// @codingStandardsIgnoreStart
protected $strictConfigSchema = FALSE;
// @codingStandardsIgnoreEnd

/**
* {@inheritdoc}
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,21 +20,6 @@ class ImageEmbedTest extends MediaEmbedTestBase {
*/
protected static $modules = ['acquia_cms_common', 'acquia_cms_image', 'focal_point'];

/**
* Disable strict config schema checks in this test.
*
* Cohesion has a lot of config schema errors, and until they are all fixed,
* this test cannot pass unless we disable strict config schema checking
* altogether. Since strict config schema isn't critically important in
* testing this functionality, it's okay to disable it for now, but it should
* be re-enabled (i.e., this property should be removed) as soon as possible.
*
* @var bool
*/
// @codingStandardsIgnoreStart
protected $strictConfigSchema = FALSE;
// @codingStandardsIgnoreEnd

/**
* {@inheritdoc}
*/
Expand Down
15 changes: 0 additions & 15 deletions modules/acquia_cms_image/tests/src/Kernel/SiteLogoTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -63,21 +63,6 @@ class SiteLogoTest extends KernelTestBase {
*/
protected $siteLogo;

/**
* Disable strict config schema checks in this test.
*
* There are some config schema errors, and until they are all fixed,
* this test cannot pass unless we disable strict config schema checking
* altogether. Since strict config schema isn't critically important in
* testing this functionality, it's okay to disable it for now, but it should
* be re-enabled (i.e., this property should be removed) as soon as possible.
*
* @var bool
*/
// @codingStandardsIgnoreStart
protected $strictConfigSchema = FALSE;
// @codingStandardsIgnoreEnd

/**
* {@inheritdoc}
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@ class PageImageDamTest extends ExistingSiteBase {

use ConfigurationTraits;

// @codingStandardsIgnoreStart
protected $strictConfigSchema = FALSE;
// @codingStandardsIgnoreEnd

/**
* {@inheritdoc}
*/
Expand Down
15 changes: 0 additions & 15 deletions modules/acquia_cms_page/tests/src/Functional/PageTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -32,21 +32,6 @@ class PageTest extends ContentTypeTestBase {
'schema_article',
];

/**
* Disable strict config schema checks in this test.
*
* Cohesion has a lot of config schema errors, and until they are all fixed,
* this test cannot pass unless we disable strict config schema checking
* altogether. Since strict config schema isn't critically important in
* testing this functionality, it's okay to disable it for now, but it should
* be re-enabled (i.e., this property should be removed) as soon as possible.
*
* @var bool
*/
// @codingStandardsIgnoreStart
protected $strictConfigSchema = FALSE;
// @codingStandardsIgnoreEnd

/**
* {@inheritdoc}
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ class PageWithLayoutCanvasFieldTest extends FieldKernelTestBase {
/**
* {@inheritdoc}
*/
// @codingStandardsIgnoreStart
protected $strictConfigSchema = FALSE;
// @codingStandardsIgnoreEnd

/**
* The field_config object.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@ class PersonImageDamTest extends ExistingSiteBase {

use ConfigurationTraits;

// @codingStandardsIgnoreStart
protected $strictConfigSchema = FALSE;
// @codingStandardsIgnoreEnd

/**
* {@inheritdoc}
*/
Expand Down
15 changes: 0 additions & 15 deletions modules/acquia_cms_person/tests/src/Functional/PersonTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,21 +35,6 @@ class PersonTest extends ContentTypeTestBase {
'schema_person',
];

/**
* Disable strict config schema checks in this test.
*
* Cohesion has a lot of config schema errors, and until they are all fixed,
* this test cannot pass unless we disable strict config schema checking
* altogether. Since strict config schema isn't critically important in
* testing this functionality, it's okay to disable it for now, but it should
* be re-enabled (i.e., this property should be removed) as soon as possible.
*
* @var bool
*/
// @codingStandardsIgnoreStart
protected $strictConfigSchema = FALSE;
// @codingStandardsIgnoreEnd

/**
* {@inheritdoc}
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@ class PlaceImageDamTest extends ExistingSiteBase {

use ConfigurationTraits;

// @codingStandardsIgnoreStart
protected $strictConfigSchema = FALSE;
// @codingStandardsIgnoreEnd

/**
* {@inheritdoc}
*/
Expand Down
Loading
Loading