Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACMS-4206: Fix site studio failing test. #1883

Merged
merged 3 commits into from
Sep 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/acquia_cms_ci.workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -251,10 +251,10 @@ jobs:
- acquia_cms_person
- acquia_cms_place
- acquia_cms_search
# - acquia_cms_site_studio
- acquia_cms_site_studio
- acquia_cms_tour
- acquia_cms_video
# - sitestudio_config_management
- sitestudio_config_management
steps:
- uses: actions/checkout@v3
- name: Use Node.js 12.13.1
Expand Down
3 changes: 3 additions & 0 deletions modules/acquia_cms_site_studio/.gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ variables:
ORCA_SUT_BRANCH: 1.x
ORCA_PACKAGES_CONFIG_ALTER: $CI_PROJECT_DIR/tests/packages_alter.yml
COMPOSER_PATCHES_FILE: $CI_PROJECT_DIR/.gitlab-ci/patches/patches.json
# Site Studio 8.0.x doesn't support 9.5.x, hence skipping 9.5.x CI jobs now
SKIP_INTEGRATED_TEST_ON_LATEST_EOL_MAJOR: 1
SKIP_INTEGRATED_TEST_ON_LATEST_EOL_MAJOR_PHP8: 1

# Do not add patch for latest EOL Major i.e 9.5.x as it's working as expected.
INTEGRATED_TEST_ON_LATEST_EOL_MAJOR:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
"Fix failing test for site studio due to missing file": "https://gist.githubusercontent.com/chandan-singh7929/978c8c3c8b6f1e2de23492e7e562c0c3/raw/f0e7770d94be862e5495ca25662a0a0d5672b785/bypass-library-version-core.patch"
},
"acquia/cohesion": {
"3457188: Module installation failure on Drupal core 10.3.0.": "https://www.drupal.org/files/issues/2024-06-26/cohesion-10.3.0.patch",
"3457220: Clicking on Browse Button of Media Browser throws error on Drupal Core 10.3.0.": "https://www.drupal.org/files/issues/2024-06-26/cohesion-3457220.patch"
"Fixed schema error": "https://www.drupal.org/files/issues/2024-09-20/fix-schema.patch"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public static function providerRoleExistNotExist(): array {
* @throws \Exception
*/
public static function providerBasicPermissions(): array {
$instance = new static();
$instance = new static('test');
return [
[
'developer',
Expand Down
Loading