Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Persistent storage #42

Merged
merged 10 commits into from
Dec 5, 2023
Merged

Persistent storage #42

merged 10 commits into from
Dec 5, 2023

Conversation

aliddell
Copy link
Member

@aliddell aliddell commented Nov 28, 2023 •
edited by nclack
Loading

Description

Implements storage_start, storage_stop, and storage_set, allowing Storage objects to be used outside of acquisition time. Also one or two small unrelated fixes.

Related acquire-project/acquire-video-runtime#125

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation
  • Other (please describe):

How has this been tested?

Tested against runtime here.

Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation, if necessary.
  • I added tests for my changes, and/or the testing strategy is described above.
  • I updated the changelog.

@aliddell aliddell marked this pull request as ready for review November 28, 2023 21:28
@aliddell
Copy link
Member Author

See related runtime PR which depends on this.

@aliddell aliddell mentioned this pull request Nov 29, 2023
Merged
nclack
nclack approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@nclack nclack left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. one typo fixed.

src/acquire-device-hal/device/hal/storage.h Outdated Show resolved Hide resolved
@aliddell aliddell merged commit 60cb52c into acquire-project:main Dec 5, 2023
3 checks passed
@aliddell aliddell deleted the persistent-storage branch December 5, 2023 14:06
aliddell added a commit to acquire-project/acquire-video-runtime that referenced this pull request Dec 5, 2023
@aliddell @nclack
Persistent storage (#125)
f281c20 
- Don't destroy the `Storage` object at the end of acquisition.
- Expect non-null `Storage` pointer on `video_sink_start()`.
- Remove some unused code.
- Update `one-video-stream` test to use simulated: empty.

Depends on acquire-project/acquire-core-libs#42

---------

Co-authored-by: Nathan Clack <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nclack nclack nclack approved these changes

@andy-sweet andy-sweet Awaiting requested review from andy-sweet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aliddell @nclack