-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(home): products section #10
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - one question on the colors
@@ -22,7 +22,7 @@ export function StatBox({ | |||
<div className="group"> | |||
<div | |||
className={twMerge( | |||
"group flex flex-col rounded-2xl border border-grey-600 px-4 pb-6 transition sm:pb-10", | |||
"group flex flex-col rounded-2xl border border-light-100/[.02] px-4 pb-6 transition sm:pb-10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add this to our theme?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea would make sense 🤔 In Figma, we don't have a name for this though. So using this opacity syntax might actually be better than coming up with some theme variable name. wdyt?
Closes ACX-1869