improve(hardhat): Autogenerate network config #833
+56
−224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Network config can be derived from the common network definitions that already exist upstream in the constants repository. This saves time when adding new chains and reduces duplication.
pxrl
commented
Jan 3, 2025
hardhat.config.ts
Outdated
| const name = network.name.replace(" ", "").toLowerCase(); | ||
| const hubChainId = Object.values(MAINNET_CHAIN_IDs).includes(chainId) ? CHAIN_IDs.MAINNET : CHAIN_IDs.SEPOLIA; | ||
| const chainDef = { | ||
| url: network.publicRPC, |
There was a problem hiding this comment.
nb. depends on this PR: across-protocol/constants#88
pxrl
commented
Jan 3, 2025
pxrl
commented
Jan 3, 2025
| accounts: { mnemonic }, | ||
| companionNetworks: { l1: "mainnet" }, | ||
| }, | ||
| ...networks, // autogenerated | ||
| }, | ||
| gasReporter: { enabled: process.env.REPORT_GAS !== undefined, currency: "USD" }, | ||
| etherscan: { |
There was a problem hiding this comment.
I'll be interested to see if we can autogenerate some of this config as well.
pxrl
commented
Jan 3, 2025
hardhat.config.ts
Outdated
| .filter((chainId) => PUBLIC_NETWORKS[chainId] !== undefined) | ||
| .map((chainId) => { | ||
| const network = PUBLIC_NETWORKS[chainId]; | ||
| const name = network.name.replace(" ", "").toLowerCase(); |
There was a problem hiding this comment.
nb. might need to add some special handling for the -sepolia chains.
There was a problem hiding this comment.
In 61f2d29 I reverted to using the chainId as the network key, rather than a symbolic name. The problem with symbolic names is that we have no consistent naming scheme for the various networks. Chain IDs are at least universally consistent and don't impose decisions like whether to hyphenate spaces or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Network config can be derived from the common network definitions that already exist upstream in the constants repository. This saves time when adding new chains and reduces duplication.