feat: Add origin chain fee multipliers #1365
Draft
+152
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Applies `priorityFeeMultiplier` to Linea's priority fee rather than the `baseFeeMultiplier` - Allows caller to set a floor on any EIP1559's `priorityFee` with a default of 0.5 gwei for chainId=1 hardcoded
Currently we apply a markup to gas fees based on the chain where the fill transaction is expected to be sent. We can improve this even further by adding additional fee multipliers based on where the deposit is originating from. For example, some chains have higher re-org risk so the deposit to fill latency is expected to be longer than for lower re-org-risk destinations.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nicholaspai
commented
Jan 9, 2025
| // a higher buffer should be applied on the estimated gas price to allow for more volatility. | ||
| export const originChainBaseFeeMarkup: { | ||
| [chainId: string]: number; | ||
| } = JSON.parse(ORIGIN_BASE_FEE_MARKUP || "{}"); |
There was a problem hiding this comment.
we might need to make this a origin-destination keyed dictionary. Otherwise this multiplier isn't very useful since the actual multiplier we want to apply is based on the destination chain gas process
We should pass the pre-computed gas price into this call so that we don't query the gas price twice. Additionally, we can use the scaled up gas price value to derive the gas fee totals, which currently are not using the scaled up values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we apply a markup to gas fees based on the chain where the fill transaction is expected to be sent. We can improve this even further by adding additional fee multipliers based on where the deposit is originating from. For example, some chains have higher re-org risk so the deposit to fill latency is expected to be longer than for lower re-org-risk destinations.