feat(hyperliquid): estimate fees properly #1384
Merged
+197
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: james-a-morris <[email protected]>
james-a-morris
requested review from
mrice32,
nicholaspai,
dohaki and
gsteenkamp89
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
james-a-morris
merged commit e2603a3
into
james/hyperliquid-integration
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update sets the fees more accurately by calling into the suggested fees API endpoint with a simulated message payload.
The caveat here is that due to rounding issues there's sometimes a 1 unit refund against the recipient (0.000001 USDC). Examples:* https://arbiscan.io/tx/0x0ad884bf8eadcda92a2ad3fc55d62d79bac30ac80c83f0d0c32e04b06e8ace56* https://arbiscan.io/tx/0xc800914ff0d79bc6c5032abfe3a90cfbd35c48109420b1d0f1b04d4720dab0f5