-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP : Introduce multi-stage caching #117
base: master
Are you sure you want to change the base?
Conversation
@@ -65,9 +66,15 @@ def _db_storage(self): | |||
IrAttachment._storage = orig | |||
|
|||
|
|||
def odoo_createdb(dbname, demo, module_names, force_db_storage): | |||
def odoo_createdb(dbcache, dbname, demo, module_names, force_db_storage): | |||
core_module_names = set(module_names).intersection(core_addons[odoo.release.series]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For getting all core module needed we should be smarter and search from dependency of module_names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebastienbeau You can look at https://pypi.org/project/manifestoo/
@sbidoul I don't know if this is scheduled to integrate it here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#114 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback I am going to look at it
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
==========================================
- Coverage 93.16% 92.78% -0.38%
==========================================
Files 14 14
Lines 892 901 +9
Branches 157 159 +2
==========================================
+ Hits 831 836 +5
- Misses 43 45 +2
- Partials 18 20 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. |
I think about multi-stage caching. It's be better to install modules in few stages. |
The idea is to install first core addons (with cache) then install additionnal addons.
This allow a better reuse of caching and also solve some installation cache (sometime we need first to install all core module)
I will battle test it.