fix(dbcache): max age semantics #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 14, 2019 15:54
max size = 2 -> 2 database max age = 2 -> day-1 database - WRONG maz age = 2 -> day-2 database - RIGHT
|
Marking this as WIP. Please elaborate what the issue is and check why your change breaks tests. |
|
Max Size has an exclusive upper boundary while Max age has an inclusive upper boundary. They should have both an exclusive upper boundary as "max" can be semantically expanded to "maximum permitted". |
|
Tests are red, so this changes the behavior. I'd rather change the documentation (if needed at all). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max size = 2 -> 2 database
max age = 2 -> today-1 database - WRONG
maz age = 2 -> today-2 database - RIGHT
Given that with max size, semantics are
[max_size[, it doesn't align to have[max_age]