ci: publish latest tag based on matrix

[toast-gear]

@Link- the latest tag appears to have been added to the non-latest step which has broken many deployments as the 22.04 is signficantly different to the 20.04 image

We were going to deprecate the latest tag entirely actions/actions-runner-controller#2056 as we can't shift people without breaking lots of deployments and we don't really have a means for communicating with people so it seemed like it wasn't viable. The tags ubuntu-20.04 and ubuntu-22.04 were to act as latest for each specific OS for people who are happy to just pull the latest and can then migrate to the newer OS in a controlled manner

[toast-gear]

Additionally the GitHub Packages publish doesn't appear to work https://github.com/actions/actions-runner-controller/pkgs/container/actions-runner-controller%2Factions-runner. The workflow run seems happy but no packages, I wonder if the fact it's redirect from actions-runner-controller to actions is related.

[florianmutter]

Not sure if it belongs to this PR or not but I think updating the ubuntu-22-04 tag is missing. If I don't want to use latest I would have to use a version. Is this intended?

[kuuji]

Not sure if it belongs to this PR or not but I think updating the ubuntu-22-04 tag is missing. If I don't want to use latest I would have to use a version. Is this intended?

Same thing with the 20.04 tag I think. I noticed it was last pushed a bit ago (17 days).

[Link-]

Thank you @toast-gear for addressing this so swiftly

[Link-]

Rebuilding and pushing the images again after this change: https://github.com/actions-runner-controller/releases/actions/runs/3913800459

[Link-]

@toast-gear in that workflow you referenced, GHCR terminated the connection for one of the jobs (we're looking into this). This shouldn't be the norm though.

[toast-gear]

Yeh when I said looked fine I meant more the other runs, we've had GHCR close connections from time to time since we started publishing to GHCR (it would be great if it to work everytime though ofc!). The other runs succeeded so I would the expect to see those images in GHCR, for example ghcr.io/actions-runner-controller/actions-runner-controller/actions-runner:v2.300.2-ubuntu-20.04 completed fine but you don't see it in https://github.com/actions/actions-runner-controller/pkgs/container/actions-runner-controller%2Factions-runner.

[Link-]

Yeh when I said looked fine I meant more the other runs, we've had GHCR close connections from time to time since we started publishing to GHCR (it would be great if it to work everytime though ofc!). The other runs succeeded so I would the expect to see those images in GHCR, for example ghcr.io/actions-runner-controller/actions-runner-controller/actions-runner:v2.300.2-ubuntu-20.04 completed fine but you don't see it in https://github.com/actions/actions-runner-controller/pkgs/container/actions-runner-controller%2Factions-runner.

That's because the images are here:
https://github.com/actions-runner-controller/actions-runner-controller/pkgs/container/actions-runner-controller%2Factions-runner

They're still in the old organisation as they're owned by it. That's part of the reason we had to jump through the hoops to build these split workflows. The naming problems are a known issue that the team is addressing.