chore: update to use go1.21 #410
Conversation
| @@ -17,7 +17,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| cache: [false, true] | |||
| go: [1.20.1] | |||
| go: [1.21.0] | |||
There was a problem hiding this comment.
This job tests is the link created for non-default go installation and it does not make sense to change it. It is just "any version that is not preinstalled in the toolcache"
|
The check has failed https://github.com/actions/setup-go/actions/runs/5821942042/job/15811878197?pr=410 because the PR should wait till the 1.21 has been deployed to the runners. |
|
I checked the default go is not 21 yet |
|
rebased to the latest main and rerun the build |
|
cc @dsame @dmitry-shibanov |
|
ping @dsame @dmitry-shibanov |
README.md
Outdated
| > go-version: '1.21' | ||
| > ``` | ||
| > | ||
| > The recommendation is based on the YAML parser's behavior, which interprets non-wrapped values as numbers and, in the case of version 1.20, trims it down to 1.2, which may not be very obvious. | ||
| > The recommendation is based on the YAML parser's behavior, which interprets non-wrapped values as numbers and, in the case of version 1.21, trims it down to 1.2, which may not be very obvious. |
There was a problem hiding this comment.
It won't be the case. YAML removes 0 if it is not a string that is why you need to revert these changes.
There was a problem hiding this comment.
or sorry, this with a global replace, let me revert this. good catch.
There was a problem hiding this comment.
Hello @chenrui333. It looks like you didn't change it.
|
Thank you for your changes @chenrui333. Could you please revert changes related to |
Signed-off-by: Rui Chen <[email protected]>
|
sorry about the hassle, I just recommit the change, which is better for review now :) (not sure how I messed up with the master branch merge commit 😮💨 ) |
|
Thanks for the patience :) |
|
Encountered below issue when running Azure DevOps pipeline. Version 1.19 is the current working at my end. ##[error]Failed to download version 1.21. Please verify that the version is valid and resolve any other issues. Error: Unexpected HTTP response: 404 I think, it downloads from this link https://storage.googleapis.com/golang/go1.21.windows-amd64.zip which is empty. Could somebody help me on this. Thanks in advance. |
|
@Jayzon2019 you should use 1.21.0 or 1.21.1 rather than 1.21, which would resolve your issue |
|
@chenrui333 . A thousand thanks to you. I tried 1.21.1 and it was successful. I appreciate the immediate assistance. |
Description:
With go1.21 release, bump the golang usage/docs to it
Related issue:
n/a
Check list: