Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend using pip for simple poetry projects #471

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

scooby
Copy link
Contributor

@scooby scooby commented Jul 25, 2022

Description:
This is a brief addition to the README that simplifies a common use-case: poetry projects that are simply installed via poetry install can usually be simply pip installed.

Obviously, users that need to use, e.g. poetry publish can't take advantage of this.

But most use cases are simply poetry install and then running everything in a virtualenv.

If you are keeping your workflows simple, though, you already have isolation: the CI runner.

Does it really work? The build-system section will direct pip to load poetry_core to perform the actual build. That was the point of PEP 517.

And poetry.lock is fully specifiying everything that needs to be cached.

Related issue:
#374 flags an incorrect python version being loaded. #369 questions why you need to install poetry. For those users that can do without the full poetry CLI, this solves those problems implicitly.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

Add a section to advise using only pip instead of poetry.
@scooby scooby requested a review from a team July 25, 2022 18:37
@marko-zivic-93 marko-zivic-93 merged commit 5df6377 into actions:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants