remove：remove unuse model func, add task status for completion workflow

actiontech · Oct 8, 2024 · eca1aed · eca1aed
1 parent 50d9537
commit eca1aed
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/sqle/model/task.go b/sqle/model/task.go
@@ -527,11 +527,6 @@ func (s *Storage) UpdateTaskStatusByIDs(taskIDs []uint, attrs interface{}) error
 	return errors.ConnectStorageErrWrapper(err)
 }
 
-func updateExecuteSQLStatusByTaskId(tx *gorm.DB, taskId uint, status string) error {
-	query := "UPDATE execute_sql_detail SET exec_status=? WHERE task_id=?"
-	return tx.Exec(query, status, taskId).Error
-}
-
 func updateExecuteSQLStatusByTaskIdAndStatus(tx *gorm.DB, taskId uint, status []string, updateToStatus string) error {
 	query := "UPDATE execute_sql_detail SET exec_status=? WHERE task_id=? AND exec_status IN (?)"
 	return tx.Exec(query, updateToStatus, taskId, status).Error

diff --git a/sqle/model/workflow.go b/sqle/model/workflow.go
@@ -830,7 +830,7 @@ func (s *Storage) CompletionWorkflow(w *Workflow, operateStep *WorkflowStep, nee
 			if err != nil {
 				return err
 			}
-			err = updateTaskStatusByIdAndStatus(tx, inst.TaskId, []string{TaskStatusExecuteFailed}, TaskStatusManuallyExecuted)
+			err = updateTaskStatusByIdAndStatus(tx, inst.TaskId, []string{TaskStatusAudited, TaskStatusExecuteFailed}, TaskStatusManuallyExecuted)
 			if err != nil {
 				return err
 			}