New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: MySQL数据源支持基于识别自定义分隔符以及识别BeginEnd语句块切分SQL文本 #2636

Merged

sjjian merged 23 commits into main from issue-2406

Oct 30, 2024

Collaborator

winfredLIN commented Sep 27, 2024 •

edited

Loading

assign in @sjjian
link #2474

关联的 issue

描述你的变更

增加了新的splitter用于切分和解析SQL文本

确认项（pr提交后操作）

Tip

请在指定复审人之前，确认并完成以下事项，完成后✅

我已完成自测
我已在关联的issue里补充了实现方案
我已在关联的issue里补充了测试影响面
我已确认了变更的兼容性，如果不兼容则在issue里标记 not_compatible
我已确认了是否要更新文档，如果要更新则在issue里标记 need_update_doc

winfredLIN added 8 commits

September 27, 2024 10:32


          feat: delimiter can identifying delimiter definitions syntax and deli…

100e845

…miters


          feat: block can match begin and end of some sql block

63d9001


          feat: splitter can split sql text into sqls

a02896e


          test: unit test for splitter

ffad400


          modify: use splitter instead of origin parser to parse sql text

4988a79


          ci: no lint this error check

b977faa


          ci: no error check of this method use

f2aca99


          chore: update dependency of parser

65907ff

winfredLIN requested a review from sjjian

September 27, 2024 02:47

Member

actiontech-bot commented Sep 27, 2024

你指定的复审人没有权限复审当前项目, 更换复审人或前往首页更改项目复审权限

Member

actiontech-bot commented Sep 27, 2024

没有在复审记录中找到这个MR => #2474

winfredLIN added 2 commits

September 27, 2024 10:56


          rename: matcheDelimiterCommand to matchedDelimiterCommand

d93809e


          modify: handle error while using reset method

737ded1

sjjian reviewed

View reviewed changes

sqle/driver/mysql/splitter/splitter.go Outdated Show resolved Hide resolved


          modify: handle error return by Parse()

0e0ea93

winfredLIN commented

View reviewed changes

sqle/driver/mysql/splitter/delimiter.go Outdated Show resolved Hide resolved


          modify: the logic of judging delimiter

3543efc

winfredLIN commented

View reviewed changes

sqle/driver/mysql/splitter/delimiter.go Outdated Show resolved Hide resolved

winfredLIN commented

View reviewed changes

sqle/driver/mysql/splitter/splitter.go Outdated Show resolved Hide resolved

winfredLIN commented

View reviewed changes

sqle/driver/mysql/splitter/splitter.go Outdated Show resolved Hide resolved

winfredLIN commented

View reviewed changes

sqle/driver/mysql/splitter/delimiter.go Outdated Show resolved Hide resolved

winfredLIN commented

View reviewed changes

sqle/driver/mysql/splitter/splitter.go Outdated Show resolved Hide resolved


          modify: optimize get and set delimiter value

2a7f4c1

winfredLIN commented

View reviewed changes

sqle/driver/mysql/splitter/splitter.go Outdated Show resolved Hide resolved

winfredLIN added 5 commits

October 8, 2024 14:31


          test: modify some test case that can not execute in fact

5ad36b1


          test: exchange expected and actual results

1ab78e0


          modify: end pos is after the end of delimiter

ebb4809


          modify: jumping out of the beginning End statement block

19a9ed6


          modify: use parse one statement instead

5c85cef

sjjian reviewed

View reviewed changes

sqle/driver/mysql/splitter/splitter.go Outdated Show resolved Hide resolved


          rename: matche -> match

eb80ec2

sjjian reviewed

View reviewed changes

sqle/driver/mysql/splitter/splitter.go Outdated Show resolved Hide resolved

sjjian reviewed

View reviewed changes

sqle/driver/mysql/splitter/splitter.go Show resolved Hide resolved

sjjian reviewed

View reviewed changes

sqle/driver/mysql/splitter/splitter.go Outdated Show resolved Hide resolved

sjjian reviewed

View reviewed changes

sqle/driver/mysql/splitter/splitter.go Outdated Show resolved Hide resolved

sjjian reviewed

View reviewed changes

sqle/driver/mysql/splitter/splitter.go Outdated Show resolved Hide resolved

sjjian reviewed

View reviewed changes

sqle/driver/mysql/splitter/delimiter.go Outdated Show resolved Hide resolved

winfredLIN added 4 commits

October 10, 2024 15:01


          modify: correct words and resolve error

6e5d77d


          modify: process sql totally in splitSqlText

18133dc


          modify: splitSqlText will not return delimiter command so modify unit…

5ef7b15

… test


          modify: cancel use of formatted sql and format sql in origin sql

e14f526

sjjian approved these changes

View reviewed changes

sjjian merged commit 74668bb into main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet