Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: it is not allowed to execute workflow that have pre-workflow was not executed correctly #2651

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

winfredLIN
Copy link
Collaborator

@winfredLIN winfredLIN commented Oct 9, 2024

关联的 issue

https://github.com/actiontech/sqle-ee/issues/1807
https://github.com/actiontech/sqle-ee/issues/1807#issuecomment-2401551908
link: https://github.com/actiontech/sqle-ee/pull/1875

描述你的变更

  1. 修改工单详情接口,增加2个字段,标记工单能否执行,前端根据能否执行置灰或者正常显示按钮
  2. 在执行工单的相应接口,增加对工单是否能执行的前置条件校验

功能特性:页面上将用户不能执行的工单的执行按钮颜色变成灰色的特性
限制条件:当工单状态为等待执行时,且工单绑定了SQL版本的某个阶段,且该工单在该阶段中,位于工单前面的工单存在状态不是已关闭或者成功执行的两种状态之一,则不允许执行该工单的sql

确认项(pr提交后操作)

Tip

请在指定复审人之前,确认并完成以下事项,完成后✅


  • 我已完成自测
  • 我已在关联的issue里补充了实现方案
  • 我已在关联的issue里补充了测试影响面
  • 我已确认了变更的兼容性,如果不兼容则在issue里标记 not_compatible
  • 我已确认了是否要更新文档,如果要更新则在issue里标记 need_update_doc

assign in @ColdWaterLW

@winfredLIN winfredLIN self-assigned this Oct 9, 2024
@ColdWaterLW ColdWaterLW merged commit 88eaed8 into main Oct 10, 2024
3 checks passed
@ColdWaterLW ColdWaterLW deleted the issue-1807-winfred branch October 10, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants