Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the SQL version is not displayed in the workflow detail #2652

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

winfredLIN
Copy link
Collaborator

@winfredLIN winfredLIN commented Oct 9, 2024

assign in @iwanghc

关联的 issue

https://github.com/actiontech/sqle-ee/issues/1807
https://github.com/actiontech/sqle-ee/issues/1807#issuecomment-2401771413
link:https://github.com/actiontech/sqle-ee/pull/1877/files

描述你的变更

  1. 增加查询工单对应的sqlversion,
  2. 如果没有就不返回工单的sql版本,前端也不显示
  3. 如果有,前端就会显示该版本名称

确认项(pr提交后操作)

Tip

请在指定复审人之前,确认并完成以下事项,完成后✅


  • 我已完成自测
  • 我已在关联的issue里补充了实现方案
  • 我已在关联的issue里补充了测试影响面
  • 我已确认了变更的兼容性,如果不兼容则在issue里标记 not_compatible
  • 我已确认了是否要更新文档,如果要更新则在issue里标记 need_update_doc

@winfredLIN winfredLIN self-assigned this Oct 9, 2024
@actiontech-bot
Copy link
Member

你指定的复审人没有权限复审当前项目, 更换复审人或前往首页更改项目复审权限

@ColdWaterLW ColdWaterLW requested review from iwanghc and removed request for ColdWaterLW October 9, 2024 09:58
@actiontech-bot
Copy link
Member

你指定的复审人没有权限复审当前项目, 更换复审人或前往首页更改项目复审权限

@ColdWaterLW ColdWaterLW merged commit bcc6e07 into main Oct 9, 2024
3 checks passed
@ColdWaterLW ColdWaterLW deleted the issue-1807-fix01 branch October 9, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants