Include empty attributes in HTML output #543
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a full revert of commit 1526789 which was a bad change. Empty attributes are valid HTML (e.g. boolean attributes) and should be supported in Arbre. The bad commit was for just addressing the class attribute but that applied to any attribute in HTML when it shouldn't have, even for just class. Note that if an attribute value is
nil
then it is removed. This follows same output logic to the Railstag.attributes
helper method.With this change, the generated HTML string is improved:
Prior to this change, the output for that would have been:
This will be in a major (v2) release due to being a breaking change.