-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Concurrency Model #2634
Draft
nvoxland
wants to merge
62
commits into
main
Choose a base branch
from
deeplog
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
New Concurrency Model #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # deeplake/core/dataset/dataset.py # deeplake/core/tensor.py # deeplake/deeplog/actions.py # deeplake/deeplog/deeplog.py # deeplake/util/version_control.py
Fixed action filtering
- Defined version 0 as "no data" (so no 000.json file) - Main branch is a random-generated id like any other branch - Collapsed methods into metadata_snapshot->find_branch()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 🚀 Pull Request
Impact
Description
Replaces the existing lock-based write consistency system with a new commit-log style system inspired by Delta Lake.
With this system, there is a now a new
_deeplake_log
directory which store atomically created files describing the operations performed against deeplake. Files in the root of that directory correspond to changes to the "main" branch, and sub-directories contain operations for different branches.Example directory structure:
With an example json file of:
Readers are always working from a particular branch + version based on the file name, such as
e8d4ce5b70e8476fb811
+2
and build up the current state by union-ing all the json files. All files (both deep log files plus data files) are immutable, with new versions specifying new file versions rather than overwriting them.For optimization purposes, the unioned json files are periodically
checkpoint()
ed into parquet files, and unused files can bevacuumed()
away.See https://hubdb.slack.com/archives/C01HCMDL97F for more information
Things to be aware of
In progress...
Things to worry about
In progress...
Additional Context
In progress...