-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ManagedDB] Rest API based Thin client for ManagedService #2666
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2666 +/- ##
==========================================
- Coverage 84.41% 82.33% -2.09%
==========================================
Files 231 234 +3
Lines 26437 26906 +469
==========================================
- Hits 22316 22152 -164
- Misses 4121 4754 +633
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! |
9d68bb9
to
de04c28
Compare
…e into managed-thin-client
0763abf
to
c0a76dd
Compare
…e into managed-thin-client
…e into managed-thin-client
Quality Gate failedFailed conditions |
🚀 🚀 Pull Request
Impact
Description
Creating a thin Rest-API client that communicates with the ManagedService.
Main idea, is that most computations shall happen not on client side, and the wrapper should only handle the communication part, with nice and intuitive wrappers, replicating regular VectorStore Interface.
Things to be aware of
Current version excludes the ability of the user to pass any functions / UDFs. Therefore
embedding_function
andfilter
parameters will throwNotImplementedError
, if passed.filter
only supports a dictionary.Things to worry about
Additional Context