VisaNet Peru: Pass amount in capture requests #3402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing amounts in capture requests will allow for partial captures. Remote: Current test credentials are expired so this will need to be confirmed in production environment and any issues soon addressed. Unit: 15 tests, 75 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
|
The requesting customer is the only user of this gateway and is willing to test in production. We'll hold off merging until we know they are ready. |
|
It looks like this gateway only uses one currency? I'm remembering the complication caused by always passing Would be good to see them test full captures as well. |
|
Hoping Bluesnap is an outlier. Otherwise we should probably a start an initiative to address those situations at a higher level. Good idea to ask them to check both though. |
|
Marking this "of interest" before a cleanup of stale PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing amounts in capture requests will allow for partial captures.
Remote: Current test credentials are expired so this will need to be
confirmed in production environment and any issues soon addressed.
Unit:
15 tests, 75 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed