Change shopify-money version to >= 2.0 in gemspec. #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gemfile already had shopify-money with no version bounds. Remove obsolete paragraph about being able to use either money gem, since 3.0 this only supports shopify-money anyway.
AnotherJoSmith
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shopify wants to update offsite_payments to 3.0. However, there is a conflicting dependency on
shopify-money. In core, we want 3.0 but offsite_payments specifies~> 2.0.This dependency is only present in the gemspec, but not in Gemfile - it's unbounded there.
Additionally, since version 3.0 this gem no longer supports non-Shopify Money gem, so removed that section from the README.