-
Notifications
You must be signed in to change notification settings - Fork 51
Drop support for ruby 1.9 and rails <4.1 #32
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,18 +20,12 @@ Gem::Specification.new do |s| | |
|
||
s.rubyforge_project = "polyamorous" | ||
|
||
s.add_dependency 'activerecord', '>= 3.0' | ||
s.add_dependency 'activerecord', '>= 4.2' | ||
s.add_development_dependency 'rspec', '~> 3' | ||
s.add_development_dependency 'machinist', '~> 1.0.6' | ||
s.add_development_dependency 'faker', '~> 1.6.5' | ||
s.add_development_dependency 'sqlite3', '~> 1.3.3' | ||
|
||
s.files = `git ls-files`.split("\n") | ||
s.test_files = `git ls-files -- {test,spec,features}/*`.split("\n") | ||
s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } | ||
s.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) } | ||
s.require_paths = ["lib"] | ||
|
||
# specify any dependencies here; for example: | ||
# s.add_development_dependency "rspec" | ||
# s.add_runtime_dependency "rest-client" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perhaps removing the old versions from .travis.yml and re-running the tests is a good idea? https://github.com/activerecord-hackery/polyamorous/blob/master/.travis.yml There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You mean also dropping support for ruby 2.2 and ruby 2.3, or excluding those entries? In any case, tests are failing against Rails master, I guess the best solution for now would be to move the failing entries to |
||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes seem unrelated?