Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Combine color attributes into light/dark mode custom Tailwind classes (#751) #1014

Closed

Conversation

BatatiDE
Copy link

Summary

This PR addresses issue #751 by combining light and dark mode Tailwind classes into unified custom classes.

Changes

  • Created brand classes in frontend/assets/css/tailwind.css, such as text-brand, bg-brand, and border-brand
  • Applied the new brand classes across components and pages to replace repetitive classes
  • Improved maintainability of light/dark mode styles

Testing

  • Verified styles in both light and dark modes
  • Confirmed updated classes are applied consistently across the platform

Related Issue

Closes #751

…lasses (activist-org#751)

- Added brand classes like 	ext-brand, �g-brand, and �order-brand to 	ailwind.css
- Updated components to use these new brand classes for consistent styling
- Reduced repetitive Tailwind classes for light and dark modes
- Improved maintainability and readability of styles across components and pages
Copy link
Contributor

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo

Copy link

netlify bot commented Nov 16, 2024

Deploy Preview for activist-org failed.

Name Link
🔨 Latest commit 1e8d2bc
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/6738dc0877d5ce00088c79eb

@andrewtavis
Copy link
Member

Hi @BatatiDE 👋 Sorry, but the issue you've opened this for is going to be closed as we're taking a different direction with this. Appreciate the interest in the platform!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine color attributes into light/dark mode custom Tailwind classes
2 participants