Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize i18n keys #948

Merged

Conversation

jennethydyrova
Copy link
Contributor

Contributor checklist


Description

  1. Standardized all i18n keys by converting them to snake_case.
  2. Updated STYLEGUIDE.md to reflect the new standard for naming keys using snake_case.

I manually verified the renaming of all keys by searching the codebase for the old key versions, and confirmed that none were found.

I apologize in advance for a big PR 🙂

Related issue

Copy link
Contributor

github-actions bot commented Aug 15, 2024

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit fd77c70
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/66d10b185f366a000864aeec
😎 Deploy Preview https://deploy-preview-948--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andrewtavis
Copy link
Member

Thanks so much for this, @jennethydyrova! I'll try to get to the review soon :)

@andrewtavis andrewtavis self-requested a review August 15, 2024 21:07
@andrewtavis
Copy link
Member

Hey @jennethydyrova 👋 Quick note that I'm going to wait on #946 to close this out as if I merge this in first the conflicts are gonna be pretty crazy 😊 Do have it in mind though!

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was quite the effort, @jennethydyrova, and I really appreciate all that you did here! Lots of changes on my end as well :) To let you know what's happened:

  • I made some new scripts after discussing with another contributor and those are checking the validity of our keys based on the file in which they're used
  • I also wrote a minor check to make sure that there are no keys used in target files that aren't in the source file
  • Based on those scripts I made the changes that just came through

Really great to have this done! Thanks so much 😊 Hope to work with you again :)

@andrewtavis andrewtavis merged commit b4219f6 into activist-org:main Aug 30, 2024
7 checks passed
@andrewtavis andrewtavis mentioned this pull request Aug 30, 2024
2 tasks
@jennethydyrova
Copy link
Contributor Author

This was quite the effort, @jennethydyrova, and I really appreciate all that you did here! Lots of changes on my end as well :) To let you know what's happened:

  • I made some new scripts after discussing with another contributor and those are checking the validity of our keys based on the file in which they're used
  • I also wrote a minor check to make sure that there are no keys used in target files that aren't in the source file
  • Based on those scripts I made the changes that just came through

Really great to have this done! Thanks so much 😊 Hope to work with you again :)

Thank you, Andrew!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants