-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize i18n keys #948
Standardize i18n keys #948
Conversation
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks so much for this, @jennethydyrova! I'll try to get to the review soon :) |
Hey @jennethydyrova 👋 Quick note that I'm going to wait on #946 to close this out as if I merge this in first the conflicts are gonna be pretty crazy 😊 Do have it in mind though! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was quite the effort, @jennethydyrova, and I really appreciate all that you did here! Lots of changes on my end as well :) To let you know what's happened:
- I made some new scripts after discussing with another contributor and those are checking the validity of our keys based on the file in which they're used
- I also wrote a minor check to make sure that there are no keys used in target files that aren't in the source file
- Based on those scripts I made the changes that just came through
Really great to have this done! Thanks so much 😊 Hope to work with you again :)
Thank you, Andrew! |
Contributor checklist
Description
I manually verified the renaming of all keys by searching the codebase for the old key versions, and confirmed that none were found.
I apologize in advance for a big PR 🙂
Related issue