Share mass contacts #22
Conversation
| } else { | ||
| setViewChecked(false); | ||
| setShareChecked(false); | ||
| removeInvitation(record.describes); | ||
| updateRecord({ ...record, canViewEvent: false }) |
There was a problem hiding this comment.
If we remove the view right, then we should also remove the share right. (That's the current behaviour)
| return ( | ||
| <List dense className={classes.list}> | ||
| {ids.map((id, i) => ( | ||
| {isOrganizer && ( |
There was a problem hiding this comment.
It would be important that the "All contacts" share button is also available for non-organizers (in this case, we would see only one toggle)
| <ListItemAvatar className={classes.avatarItem}> | ||
| <Avatar className={classes.avatar}> | ||
| C | ||
| </Avatar> |
There was a problem hiding this comment.
Could you use a Material-UI icon to make this line very different from others ? I suggest this one:
import PublicIcon from '@material-ui/icons/Public';
| /> | ||
| <ListItemText | ||
| className={classes.secondaryText} | ||
| primary={translate('app.share.allow_view')} |
There was a problem hiding this comment.
IMO it would be better to use the same wording as other lines. There are two existing keys: app.permission.view and app.permission.share.
|
@andreipopa-who Do you think you can finish this PR soon ? I need it for #27. Otherwise I will finish it myself. |
andreipopa-who
force-pushed
the
share-mass-contacts
branch
from
e09ae6e to
571db1d
Compare
|
Closing in favor of #38, which takes up on the work done in this PR. Thanks @andreipopa-who ! |
Add a new list item in order to allow the mass selection of view/share on contacts.