Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middleware for caching succesful GET responses with Redis automatically #630

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

bangbaew
Copy link

No description provided.

@bangbaew bangbaew changed the title Middleware for auto caching succesful GET responses with redis Middleware for caching succesful GET responses with Redis automatically Jul 24, 2023
bangbaew and others added 3 commits July 24, 2023 21:13
If no-store directive is specified, don't get Redis connection so it won't have any bottleneck connecting to the Redis server.
cache/redis-cache-middleware/Cargo.toml Outdated Show resolved Hide resolved
cache/redis-cache-middleware/src/main.rs Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests would be good if you feel like the challenge. We run redis in CI for other examples so should be easy enough to copy those.

@bangbaew
Copy link
Author

bangbaew commented Aug 5, 2023

added dependency versions and removed dead code

@robjtede
Copy link
Member

I'd be interested to merge this if we can fix the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants