fix and add option to cmake

acts-project · Jul 1, 2024 · ac484b1 · ac484b1
1 parent a357e0e
commit ac484b1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -82,8 +82,10 @@ if (ACTSVG_BUILD_TESTING OR ACTSVG_BUILD_EXAMPLES)
    endif()
 endif()
 
+option(ACTSVG_BUILD_PYTHON_BINDINGS "Build the python bindings of ACTSVG" OFF)
 if(ACTSVG_BUILD_PYTHON_BINDINGS)
   find_package(Python 3.8 REQUIRED COMPONENTS Interpreter Development)
+  option(ACTSVG_USE_SYSTEM_PYBIND11 "Pick up an existing installation of pybind11")
   if(ACTSVG_USE_SYSTEM_PYBIND11) 
     find_package(pybind11 CONFIG REQUIRED)
   else()

diff --git a/python/src/display.cpp b/python/src/display.cpp
@@ -306,7 +306,7 @@ void add_display_module(context& ctx) {
         /// @return an object (sterile if now matching view type is found)
         d.def(
             "surfaces_as_oriented_polygons",
-            [](const std::vector<const surface>& ss, const std::string& view) {
+            [](const std::vector<surface>& ss, const std::string& view) {
                 std::vector<svg::object> polygons;
                 for (const auto& s : ss) {
                     polygons.push_back(surface_as_oriented_polygon(
@@ -350,7 +350,7 @@ void add_display_module(context& ctx) {
     ///
     /// @return an object (sterile if now matching view type is found)
     d.def("surfaces_as_oriented_polygons",
-          [](const std::vector<const surface>& ss, const style::fill& f,
+          [](const std::vector<surface>& ss, const style::fill& f,
              const style::stroke& str, const std::string& view) {
               std::vector<svg::object> polygons;
               for (const auto& s : ss) {