fix: Navigation assertions in validation tools #858

niermann999 · 2024-10-16T09:30:47Z

Fixes two assertions that were triggered by navigation validation tools:

if the step stracer is set to record every step, make sure the barcode is only accessed when actually on surface
since rays return zero for 'qop', make sure the free track parameter momentum is only written to file if it can be retrieved. Otherwise write the (normalized) direction to file

io/include/detray/io/csv/track_parameters.hpp

…validation tools

sonarcloud · 2024-10-30T14:28:27Z

Quality Gate passed

niermann999 added bug Something isn't working priority: medium medium priority labels Oct 16, 2024

This comment was marked as outdated.

Sign in to view

niermann999 added the blocked This item is blocked by another item label Oct 22, 2024

niermann999 force-pushed the fix-nav-asset branch from 2c2fc94 to 0ae341b Compare October 29, 2024 20:20

niermann999 removed the blocked This item is blocked by another item label Oct 29, 2024

niermann999 force-pushed the fix-nav-asset branch from 0ae341b to f615ca0 Compare October 29, 2024 20:28

niermann999 requested a review from beomki-yeo October 30, 2024 09:00

beomki-yeo reviewed Oct 30, 2024

View reviewed changes

io/include/detray/io/csv/track_parameters.hpp Show resolved Hide resolved

beomki-yeo approved these changes Oct 30, 2024

View reviewed changes

niermann999 force-pushed the fix-nav-asset branch from f615ca0 to 013db78 Compare October 30, 2024 14:17

Fix navigation assertions that failed in conjunction with navigation …

fe881f6

…validation tools

niermann999 force-pushed the fix-nav-asset branch from 013db78 to fe881f6 Compare October 30, 2024 14:25

niermann999 merged commit 26680b6 into acts-project:main Oct 30, 2024
18 checks passed