Remove unneeded state from Runge-Kutta stepper #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
force-pushed
the
refactor/shrink_rk_state
branch
2 times, most recently
from
554f470
to
1f22b6b
Compare
|
Yeah I think this should increase the performance. You can also roughly measure the performance change by running the benchmark executable |
stephenswat
force-pushed
the
refactor/shrink_rk_state
branch
3 times, most recently
from
27faa83
to
0178c3c
Compare
niermann999
reviewed
Oct 29, 2024
stephenswat
force-pushed
the
refactor/shrink_rk_state
branch
from
9730ab2
to
36ff827
Compare
stephenswat
added a commit
that referenced
this pull request
Oct 30, 2024
This resolves the internal compiler error in #871.
stephenswat
force-pushed
the
refactor/shrink_rk_state
branch
from
36ff827
to
82d8c6e
Compare
niermann999
approved these changes
Nov 1, 2024
stephenswat
force-pushed
the
refactor/shrink_rk_state
branch
from
82d8c6e
to
882214c
Compare
Currently, the Runge-Kutta stepper holds a lot of state which is used only internally. The size of this state is 164 bytes, of which only 140 bytes are needed after the step. Keeping the remaining state between steps is therefore taking up a lot of memory. In this PR, I remove this internal state from the externally facing stepper state and turn it into an intermediate struct which is not stored persistently, saving 140 bytes on the size of the stepper state (and, with it, the propagator state).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Runge-Kutta stepper holds a lot of state which is used only internally. The size of this state is 164 bytes, of which only 140 bytes are needed after the step. Keeping the remaining state between steps is therefore taking up a lot of memory.
In this PR, I remove this internal state from the externally facing stepper state and turn it into an intermediate struct which is not stored persistently, saving 140 bytes on the size of the stepper state (and, with it, the propagator state).