Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add pre-commit config #878

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

paulgessinger
Copy link
Member

Inspired by @niermann999's #876, I'm proposing (somewhat provocatively) to synchronize the linting with the core repo. With this PR:

  • There's a pre-commit config file to allow easy local application of linting rules
  • I'm adding gersemi for CMake formatting as well as end-of-file and trailing-whitespace checkers
  • Adds a CI job that runs pre-commit, instead of individual other jobs.

I'm not changing the clang-format version here, but that would be very easy to in a follow-up step.

Copy link

sonarcloud bot commented Nov 5, 2024

Copy link
Contributor

@niermann999 niermann999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell

extern/nlohmann_json/README.md Show resolved Hide resolved
.github/workflows/checks.yml Show resolved Hide resolved
Copy link
Contributor

@niermann999 niermann999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the CI requirements have to be updated one more time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants