GCC 13.1 Fix, main branch (2024.11.08.) #882
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That version of GCC crashes in traccc's host CKF code when m_candidates is initialized explicitly with curly braces. :-/
|
niermann999
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to try to address the compiler crash that we've seen with @nribaric earlier this week, and which @flg saw this morning himself.
GCC 13.1 crashes while compiling traccc's host CKF code when
detray::navigator<...>::state::m_candidatesis initialized explicitly with curly braces. 😕I'm worried about this update though. 🤔 By removing the curly braces, do I eliminate some explicit initialization to the elements of the array? std::array has no constructor. So this change should not change anything... right? The code is initializing the array elements to something somewhere else, right? (If the logic requires some initialization that is. If not, then fine.)