Add an Ubuntu 24.04 image with CUDA #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new variant of the Ubuntu 24.04 image which incorporates CUDA 12.5.
krasznaa
reviewed
May 31, 2024
Comment on lines
+14
to
+19
| RUN apt install wget | ||
|
|
||
| RUN wget https://developer.download.nvidia.com/compute/cuda/12.5.0/local_installers/${CUDA_RUNFILE_NAME} && \ | ||
| chmod +x ${CUDA_RUNFILE_NAME} && \ | ||
| ./${CUDA_RUNFILE_NAME} --toolkit --silent --installpath=${CUDA_INSTALL_PATH} && \ | ||
| rm ${CUDA_RUNFILE_NAME} |
There was a problem hiding this comment.
I am super not on board with this implementation. Please don't merge stuff right away, and wait for us to have a look first!
You'll need to switch to the same setup that I use for all the other GPU supporting images. Installing CUDA/HIP/oneAPI using APT. Since that's the one technique that all of them support. So let's not install each of them in a different way!
I.e. go and modify this image like: https://github.com/acts-project/machines/blob/master/ubuntu2004_cuda/Dockerfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new variant of the Ubuntu 24.04 image which incorporates CUDA 12.5.