Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wait or ignore for all async copies #645

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add wait or ignore for all async copies #645

wants to merge 1 commit into from
+86 −69

Commits on Jul 17, 2024

  1. Add wait or ignore for all async copies 

    Using acts-project/vecmem#286 I was able to find
a few more cases where we do not properly wait for or ignore events. In
this PR I opted to add those missing statements according to a simple
heuristic, i.e. I added waits for all SYCL and share code and I added
ignores for all CUDA code. Reason for this is that CUDA events are
stream-ordered, so you can't really shoot yourself in the foot too much.
SYCL events, on the other hand, are unordered, so they need stricted
checking.
    @stephenswat
    stephenswat committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    8e2f281 View commit details
    Browse the repository at this point in the history