Windows SYCL Build Fix, main branch (2023.09.25.) #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting version numbers in the DLL names had to be disabled completely, as the logic around DLL_NAME_WITH_SOVERSION seems to be set on putting version numbers into the SYCL shared library DLL names otherwise. :-/ While at it, I noticed that modern CMake versions no longer need the hack of adding "/link" to the linking commands, so the code now looks for a pre-existing "/link" or "-link" argument, and only modifies the linking commands if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the SYCL build work on Windows with CMake >=3.27.
Putting version numbers in the DLL names had to be disabled completely, as the logic around DLL_NAME_WITH_SOVERSION (introduced to CMake in https://gitlab.kitware.com/cmake/cmake/-/merge_requests/8021) seems to be set on putting version numbers into the SYCL shared library DLL names otherwise. 😕
While at it, I noticed that modern CMake versions no longer need the hack of adding
/linkto the linking commands (see: https://gitlab.kitware.com/cmake/cmake/-/blob/v3.27.6/Modules/Platform/Windows-IntelLLVM.cmake?ref_type=tags#L53-57), so the code now looks for a pre-existing/linkor-linkargument, and only modifies the linking commands if necessary.