Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoogleTest Update, main branch (2023.09.25.) #238

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

krasznaa
Copy link
Member

Update to GoogleTest 1.14.0. This is mainly to avoid a warning that shows up with modern CMake versions, using older versions of GoogleTest. Like:

-- Building GoogleTest as part of the VecMem project
CMake Deprecation Warning at C:/Users/krasz/ATLAS/vecmem/build/_deps/googletest-src/CMakeLists.txt:4 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

@krasznaa krasznaa added the tests This issue or pull request is related to the test suite label Sep 25, 2023
This is mainly to avoid a warning that shows up with modern CMake
versions, using older versions of GoogleTest.
@krasznaa krasznaa force-pushed the GoogleTestUpdate-main-20230925 branch from fe6f35c to efbd090 Compare September 25, 2023 10:57
@krasznaa krasznaa merged commit a47377e into acts-project:main Sep 25, 2023
18 of 22 checks passed
@krasznaa krasznaa deleted the GoogleTestUpdate-main-20230925 branch September 25, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests This issue or pull request is related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant