Skip to content

Commit

Permalink
Improve the descriptor on an implicit group by.
Browse files Browse the repository at this point in the history
  • Loading branch information
joka921 committed Jul 26, 2024
1 parent 196a911 commit 12fdde5
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/engine/GroupBy.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,9 @@ string GroupBy::getCacheKeyImpl() const {
}

string GroupBy::getDescriptor() const {
// TODO<C++23>:: Use std::views::join_with.
if (_groupByVariables.empty()) {
return "GroupBy (implicit)";
}

Check warning on line 82 in src/engine/GroupBy.cpp

View check run for this annotation

Codecov / codecov/patch

src/engine/GroupBy.cpp#L81-L82

Added lines #L81 - L82 were not covered by tests
return "GroupBy on " +
absl::StrJoin(_groupByVariables, " ", &Variable::AbslFormatter);
}
Expand Down

0 comments on commit 12fdde5

Please sign in to comment.