Skip to content

Commit

Permalink
Write loop manually to fix clang 16 compiler error
Browse files Browse the repository at this point in the history
  • Loading branch information
RobinTF committed Nov 7, 2024
1 parent 2cf2eac commit 3466b3d
Showing 1 changed file with 6 additions and 8 deletions.
14 changes: 6 additions & 8 deletions src/engine/CartesianProductJoin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -424,14 +424,12 @@ Result::Generator CartesianProductJoin::createLazyProducer(
offset = itwm->totalOffset_;
// TODO<RobinTF> consider skipping empty id tables.
size_t currentColumn = columnOffset;
auto valueView =
row |
std::views::transform([](const auto& elem) { return *elem; }) |
std::views::join;
for (const auto& value : valueView) {
std::ranges::fill(idTable.getColumn(currentColumn), value);
currentColumn++;
checkCancellation();
for (const auto& partialRow : row) {
for (const ValueId& value : *partialRow) {
std::ranges::fill(idTable.getColumn(currentColumn), value);
currentColumn++;
checkCancellation();
}
}
}
co_yield {std::move(idTable), staticMergedVocab.clone()};
Expand Down

0 comments on commit 3466b3d

Please sign in to comment.