Skip to content

Commit

Permalink
Rename LOG(...) macro to AD_LOG_... to avoid conflicts with Abseil (
Browse files Browse the repository at this point in the history 
#1629)

So far, QLever uses the macro `LOG(...)` for logging, where the argument is the log level. This is used by other libraries, too, in particular by Abseil. With an unfortunate include order, this leads to compilation errors that are hard to understand for new developers. We now use our usual prefix also for logging and call the macros `AD_LOG_INFO`, `AD_LOG_DEBUG`, etc.

---------

Co-authored-by: Hannah Bast <[email protected]>
  • Loading branch information
@joka921
joka921 and Hannah Bast authored Nov 21, 2024
1 parent d53d4f9 commit 5f28e83
Show file tree
Hide file tree
Showing 2 changed files with 178 additions and 145 deletions.
Loading

0 comments on commit 5f28e83

Please sign in to comment.