Skip to content

Commit

Permalink
todo
Browse files Browse the repository at this point in the history
  • Loading branch information
ullingerc committed Nov 19, 2024
1 parent 5995693 commit ba4109a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
3 changes: 3 additions & 0 deletions test/QueryPlannerTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1657,6 +1657,9 @@ TEST(QueryPlanner, SpatialJoinService) {

// TODO<ullingerc> change / add tests

// TODO<ullingerc> Migrate tests from (SpatialJoin, maxDistanceParsingTest)
// here

AD_EXPECT_THROW_WITH_MESSAGE(
h::expect("SELECT ?x ?y WHERE {"
"?x <p> ?y."
Expand Down
5 changes: 3 additions & 2 deletions test/engine/SpatialJoinAlgorithmsTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ class SpatialJoinParamTest : public ::testing::TestWithParam<bool> {
for (size_t i = 0; i < vec.size(); ++i) {
EXPECT_STREQ(vec.at(i).c_str(), expectedOutput.at(i).c_str());
}*/

// TODO<ullingerc> double dist ... ?
EXPECT_THAT(vec, ::testing::UnorderedElementsAreArray(expectedOutput));
}

Expand Down Expand Up @@ -277,7 +277,8 @@ auto expectedDist = [](const GeoPoint& p1, const GeoPoint& p2) {
auto p1_ = S2Point{S2LatLng::FromDegrees(p1.getLat(), p1.getLng())};
auto p2_ = S2Point{S2LatLng::FromDegrees(p2.getLat(), p2.getLng())};

return std::to_string(static_cast<int>(S2Earth::ToMeters(S1Angle(p1_, p2_))));
// TODO<ullingerc>
return std::to_string(S2Earth::ToKm(S1Angle(p1_, p2_)));
};

// Places for testing
Expand Down

0 comments on commit ba4109a

Please sign in to comment.