Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/undefined-variables-in-expressio…
Browse files Browse the repository at this point in the history
…ns' into undefined-variables-in-expressions

# Conflicts:
#	test/QueryPlannerTestHelpers.h
  • Loading branch information
joka921 committed Nov 14, 2024
2 parents 5861e46 + c02ebb5 commit efcfcea
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions test/QueryPlannerTestHelpers.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ using QetMatcher = Matcher<const QueryExecutionTree&>;

// Return a matcher that checks that the `rootOperation` of a given
// `QueryExecutionTree` matches the given `matcher`.
QetMatcher RootOperationBase(Matcher<const Operation&> matcher) {
inline QetMatcher RootOperationBase(Matcher<const Operation&> matcher) {
auto getRootOperation =
[](const QueryExecutionTree& tree) -> const ::Operation& {
return *tree.getRootOperation().get();
Expand Down Expand Up @@ -386,11 +386,10 @@ constexpr auto OrderBy = [](const ::OrderBy::SortedVariables& sortedVariables,
// Match a `UNION` operation.
constexpr auto Union = MatchTypeAndOrderedChildren<::Union>;

// Match a `QueryExecutionTree` that contains warnings (in any order) that
// contain the `warningSubstrings` and additionally matches the `actualMatcher`.
//
inline QetMatcher QetWithWarnings(
const std::vector<std::string>& warningSubstrings,
const QetMatcher& actualMatcher) {
QetMatcher actualMatcher) {
auto warningMatchers = ad_utility::transform(
warningSubstrings,
[](const std::string& s) { return ::testing::HasSubstr(s); });
Expand Down

0 comments on commit efcfcea

Please sign in to comment.