Proper handling of (all kinds of) empty queries #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1383 +/- ##
==========================================
+ Coverage 89.05% 89.08% +0.02%
==========================================
Files 328 328
Lines 29227 29234 +7
Branches 3248 3250 +2
==========================================
+ Hits 26029 26042 +13
+ Misses 2054 2049 -5
+ Partials 1144 1143 -1 ☔ View full report in Codecov by Sentry. |
hannahbast
changed the title
hannahbast
requested changes
Jul 4, 2024
hannahbast
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty queries were properly handled so far (before the parsing), but queries that consisted only of whitespace, comments, or prefix declarations were not. The first two produced a segmentation fault, the last produced a confusing error message. Now none of these queries lead to a segmentation fault anymore, and in each case, the same proper error message is returned.