implement functions Iri() / Uri()
#1401
Conversation
This is a first draft. It does something meaningful already, but is not quite standard-conform yet. Also, I am not sure whether the `StringValueGetter` is the right way to go here, since the argument can also be an `Iri`, in which case the function should be the identity.
| IdOrLiteralOrIri IriOrUriValueGetter::operator()( | ||
| const LiteralOrIri& litOrIri, | ||
| [[maybe_unused]] const EvaluationContext* context) const { | ||
| const auto& optIri = Iri::fromIrirefWithBasicUrlCheck( |
There was a problem hiding this comment.
I think for now you should simply return the content without any normalization.
The whole resolving against base IRI stuff is something that QLever currently doesn't support at all, so we should implement it in one go at a later time.
In particlar QLever currently supports IRIs that are not valid IRIs like <is-a> etc.
The only thing that is worth considering (check what happens there), is if a string contains special characters that are not allowed in IRIs. (which are those, should we normalize them), but there I also would have to check on how to properly normalize or escape them (percent encoding? anything else?)
There was a problem hiding this comment.
Ah i see, i didn't realize that BASE was a declaration similar to a PREFIX at the beginning of a query.
Given that we implement IRI() and URI() in combination, and IRIs allow a wider range of characters, if we normalize at all, probably only w.r.t. the IRI range.
There was a problem hiding this comment.
BASE is already defined by the parser grammar, but not implemented yet. Resolving against BASE could be maybe done with help of sparqlExpression::EvaluationContext.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1401 +/- ##
==========================================
+ Coverage 89.14% 89.27% +0.13%
==========================================
Files 332 336 +4
Lines 29498 29754 +256
Branches 3291 3315 +24
==========================================
+ Hits 26296 26564 +268
+ Misses 2050 2027 -23
- Partials 1152 1163 +11 ☔ View full report in Codecov by Sentry. |
| "<https://example.org/bim%20A%00c%03doof%11c%12testescape/%13test>"; | ||
| std::string objectQuery = | ||
| "SELECT ?o WHERE { " | ||
| "BIND(IRI(<https://example.org/bim%20A%00c%03doof%11c%12testescape/" | ||
| "%13test>) AS ?o) }"; | ||
| std::string expectedXml = makeXMLHeader({"o"}) + |
There was a problem hiding this comment.
Those are not the escapes I meant, those change the meaning of the IRI.
I meant stuff like <https:\\u0020example.org>. etc.
Also the IRI function in the bind can take a literal like IRI("example\\n.org").
Let me know if you need help.
There was a problem hiding this comment.
I see that you implemented a separate test for the strings, but the first point remains valid.
|
No description provided.