Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in the cache key of DISTINCT #1403

Merged
merged 2 commits into from
Jul 18, 2024

Remove unused include

abc3653
Select commit
Loading
Failed to load commit list.
Merged

Fix a bug in the cache key of DISTINCT #1403

Remove unused include
abc3653
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 17, 2024 in 0s

89.14% (-0.01%) compared to 6a6a4b8, passed because coverage increased by -0.01% when compared to adjusted base (89.15%)

View this Pull Request on Codecov

89.14% (-0.01%) compared to 6a6a4b8, passed because coverage increased by -0.01% when compared to adjusted base (89.15%)

Details

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.14%. Comparing base (6a6a4b8) to head (abc3653).

Files Patch % Lines
src/engine/Distinct.h 62.50% 3 Missing ⚠️
src/engine/Distinct.cpp 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1403      +/-   ##
==========================================
- Coverage   89.14%   89.14%   -0.01%     
==========================================
  Files         332      332              
  Lines       29498    29497       -1     
  Branches     3291     3291              
==========================================
- Hits        26296    26295       -1     
  Misses       2050     2050              
  Partials     1152     1152              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.