Fix URL-decoding bug from previous commit #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1517 +/- ##
==========================================
- Coverage 92.55% 88.08% -4.48%
==========================================
Files 355 355
Lines 26631 26636 +5
Branches 3575 3576 +1
==========================================
- Hits 24649 23463 -1186
- Misses 1940 1947 +7
- Partials 42 1226 +1184 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Johannes Kalmbach <[email protected]>
hannahbast
changed the title
Signed-off-by: Johannes Kalmbach <[email protected]>
…rsing # Conflicts: # src/engine/Server.cpp
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For URL-decoding, now use (the well documented)
boost::urls::parse_origin_forminstead of the (internal and poorly documented)boost::urls::parse_querybecause the latter turned out to not unescape+to space.TODO for a separate PR: When the URL path is malformed, currently a Boost-internal error message is returned, like
leftover [boost.url.grammar:4]. Instead an exception should be thrown and caught and a proper error message displayed.