-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing geo:wktLiteral
datatype
#1521
Conversation
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1521 +/- ##
==========================================
- Coverage 88.12% 88.12% -0.01%
==========================================
Files 357 357
Lines 26764 26765 +1
Branches 3606 3606
==========================================
- Hits 23587 23586 -1
Misses 1941 1941
- Partials 1236 1238 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm I missed this detail and all WKT literals except points are currently missing their datatypes in the output. Thank you for spotting and fixing this.
Quality Gate passedIssues Measures |
geo:wktLiteral
datatype
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix and the corresponding test!
@ullingerc Even after this fix, there is still an inconsistency. Namely, in the TSV export, the points appear as |
This may be caused by this review: #1506 (comment) |
@hannahbast I have checked it and the bug has nothing to do specifically with my implementation in #1506 . It also affects the date type. See for example: qlever/test/ExportQueryExecutionTreesTest.cpp Lines 500 to 504 in f39907c
|
@ullingerc Thanks for the info, than this is work for a separate PR. But I just hit another problem, when trying to build the index for the latest version of Wikidata (which never had problems with coordinates in the past):
Any idea, what the problem is here? Anyway, it would be good to output the whole |
@ullingerc PS: Shortly before the parse fails, I find the following in the dataset:
|
@hannahbast It's very helpful that you found the problematic item, thanks. I think we should keep the verification for coordinates, otherwise the folding will no longer work in a meaningful way. However, I agree, the error should be handled more gracefully, similar to the example you have pointed out. |
@ullingerc I am also experiencing the same problem while parsing the latest wikidata, is there any solution for this at the moment?
|
@ldp2211479 Yes, I have proposed a solution in PR #1525 , which is unfortunately not yet merged into master. |
Thank you for your reply. I don't know much about this area, could you please provide a direct way to temporarily solve this problem for wikidata? For example, should I need to change the code |
@ldp2211479 You could either directly pull the code from the PR, or alternatively add this code manually for a quick fix: qlever/src/parser/RdfParser.cpp Lines 548 to 556 in 9c41d58
|
Thank you! |
@ldp2211479 The fix for this will probably be merged into the master today, I have just apllied a final small tweak to it and am now waiting for the CI pipeline. |
After the previous commit, all WKT literals except
POINT
s were missing thegeo:wktLiteral
datatype. This is now fixed again.