-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement lazy join #1524
Merged
Merged
Implement lazy join #1524
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
f1a67d4
Implement lazy join
RobinTF 711c3a7
Properly reformat
RobinTF 08be2d8
Fix race condition
RobinTF c9a5648
Fix lifetime issues and add documentation
RobinTF bc659c6
Properly reset runtime parameter after test
RobinTF 112a757
Properly use `LocalVocab`s from fully materialized results
RobinTF d091bba
Properly apply permutation
RobinTF f585987
Spawn thread only if generator is consumed
RobinTF 8ecc821
Fix issue with join aggregation
RobinTF 190b8de
Fix typo
RobinTF 3bbc466
Unify two generators
RobinTF 3e6561c
Fix deadlock
RobinTF ec02b9f
Use robuster approach for thread safety
RobinTF cbc6252
Add test for operation failure propagation
RobinTF f56a00b
Merge remote-tracking branch 'origin/master' into lazy-join
1f54327
Show num-local-vocabs in runtime information
99ea8ee
Merge branch 'lazy-join' of github.com:RobinTF/qlever into lazy-join
1d5dcda
Fix problem from previous conflict resolution
b2b944f
Add unit test to ensure correct permutations
RobinTF 1b55f45
Avoid out-of-line definition
RobinTF b9b7cae
Address PR comments
RobinTF 0f4f859
Address simple PR comments
RobinTF 62d9295
Allow more ranges to be used in `LocalVocab`
RobinTF c7889a6
Merge missing vocabs
RobinTF f1c886a
Merge remote-tracking branch 'ad-freiburg/master' into lazy-join
RobinTF 9e357cd
Revert "Allow more ranges to be used in `LocalVocab`"
RobinTF 711212a
Fix compilation
RobinTF 4b51d1d
Address minor PR comments
RobinTF 8e85cc7
Fix issues with vocab and add unit tests
RobinTF a8e3240
Add another unit test
RobinTF 3f817fa
Fix typo
RobinTF ad0128a
Replace else case with assertion
RobinTF f88d4b8
Check empty table instead of vocab
RobinTF 66cb836
Fix unit test
RobinTF File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely have to talk about the
LocalVocab
stuff, as this really aggressively merges the local vocabs over and over again in the following cases:I see two potential angles here:
LocalVocab
class (the most aggressive way: Use a HashMap instead of a vector for theotherWordSets
.I will ask @hannahbast what she thinks about 1. It will only have a performance impact for inputs with very many nonempty local vocabs, and these are typically slower anyway, so it seems feasible to me.