Merge located triples when performing index scans #1597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
TODO<joka921> Test the merging of the located triples. Signed-off-by: Johannes Kalmbach <[email protected]>
Check for code coverage/self-review/etc. Signed-off-by: Johannes Kalmbach <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1597 +/- ##
==========================================
+ Coverage 89.21% 89.25% +0.04%
==========================================
Files 372 372
Lines 34723 34970 +247
Branches 3915 3942 +27
==========================================
+ Hits 30979 31214 +235
- Misses 2471 2485 +14
+ Partials 1273 1271 -2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
TODO: `DeltaTriplesTest, DeltaTriplesManager` failed because `locatedSPO.containsTriple` was removed. I have commented out that code for now, but this needs to be fixed properly.
Signed-off-by: Johannes Kalmbach <[email protected]>
hannahbast
requested changes
Nov 13, 2024
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
…e-located-triples # Conflicts: # src/engine/Join.cpp
hannahbast
requested changes
Nov 13, 2024
Signed-off-by: Johannes Kalmbach <[email protected]>
Conformance check passed ✅No test result changes. |
|
|
@joka921 I will write the description for this PR tomorrow (Thursday). One more thing: SonarCloud identified 10 issues: do we want to let these go or are there some of them, which you still want to address for this PR? |
hannahbast
changed the title
hannahbast
approved these changes
Nov 14, 2024
realHannes
pushed a commit
to realHannes/qlever
that referenced
this pull request
Nov 15, 2024
PR ad-freiburg#1582 and ad-freiburg#1603 gave all index-lookup methods access to a snapshot of the (located) delta triples. With this change, these triples are now merged with the original triples during query processing whenever necessary. When an index block does not contain any located triples, the performance for accessing that block is the same as before. The methods for obtaining the result size of an index scan now have two versions: one for obtaining an approximate size (this is cheap because it can be computed from the metadata of the blocks and the located triples) and one for obtaining the exact size (if there are located triples this is expensive because it requires reading and decompressing a block and merging the located triples).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1582 and #1603 gave all index-lookup methods access to a snapshot of the (located) delta triples. With this change, these triples are now merged with the original triples during query processing whenever necessary. When an index block does not contain any located triples, the performance for accessing that block is the same as before.
The methods for obtaining the result size of an index scan now have two versions: one for obtaining an approximate size (this is cheap because it can be computed from the metadata of the blocks and the located triples) and one for obtaining the exact size (if there are located triples this is expensive because it requires reading and decompressing a block and merging the located triples).